Skip to content

feat(pydantic_ai): log invocation params on llm spans #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into from
Sep 2, 2026
Merged

feat(pydantic_ai): log invocation params on llm spans #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions py/src/braintrust/integrations/pydantic_ai/test_pydantic_ai_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,10 +965,13 @@ async def test_agent_with_model_settings_in_metadata(memory_logger):
assert chat_settings["max_tokens"] == 100
assert chat_settings["temperature"] == 0.5

# Verify model_settings is NOT in chat metadata (it's in input)
assert chat_span["span_attributes"]["type"] == SpanTypeAttribute.LLM
invocation_params = chat_span["metadata"]["invocation_params"]
assert invocation_params["max_tokens"] == 100
assert invocation_params["temperature"] == 0.5

assert "model_settings" not in chat_span["metadata"], "model_settings should NOT be in chat span metadata"

# Verify other metadata is present
assert chat_span["metadata"]["model"] == "gpt-4o-mini"
assert chat_span["metadata"]["provider"] == "openai"

Expand Down
2 changes: 2 additions & 0 deletions py/src/braintrust/integrations/pydantic_ai/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ def _build_model_class_input_and_metadata(instance: Any, args: Any, kwargs: Any)
input_data["model_settings"] = model_settings

metadata = _build_model_metadata(model_name, provider, model_settings=None)
if model_settings is not None:
metadata["invocation_params"] = model_settings

return model_name, display_name, input_data, metadata

Expand Down