Conversation
…rface Add a persisted reflection_run lifecycle table and event for the skill-reflection pump. Every reflection pass (riding the memory- persistence branch) now records agent/channel identity, trigger provenance, referenced worker IDs, start/end timestamps, terminal status (success/no_op/error), declared rationale distinct from observed actions, outcome summary, and affected skill identifiers. ReflectionRunCompleted flows through the shared ProcessEvent bus, the existing ApiEvent SSE pipeline, and renders as an inline card in the portal timeline — same pattern as chronicle checkpoints, no parallel event system. Deferred curation (snapshots, stale/archive passes, consolidation) and full SkillInspector surface remain for follow-up PRs as documented in the updated skill-lifecycle.md shipped-status section.
The reflection_run timeline type is client-only (not in the OpenAPI TimelineItem union). Use double-cast through unknown for pushItem and Record<string,unknown> for the type discriminator in PortalTimeline, matching the existing pattern used by checkpoint rendering.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
2 participants
Compatibility/port PR for spacedriveapp#641. Persists skill-reflection lifecycle records and surfaces them on the activity timeline. Staged on integration/upstream-prs.