Conversation
Cron-originated messages carry a platform source (e.g., "slack") for adapter routing but use sender_id="system". The listen-only guard only checked message.source != "system", so cron messages were silently suppressed — the channel returned without running the LLM, producing no output and skipping delivery. Add sender_id != "system" to the guard so cron messages are correctly exempted from listen-only suppression.
Upstream replaced listen_only_mode boolean with ResponseMode enum. Applied the sender_id="system" fix to the new guard and updated the test to match.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 participants
Port of spacedriveapp#519 onto the fork integration branch. Purpose: preserve cron/system-originated delivery when response mode is quiet or mention-only. Staged before main and subject to the integration CI gates.