Conversation
- Make daemonize and libc unix-only deps, add windows-sys for Windows - Split daemon.rs into unix/windows modules with cfg guards - Add Windows GetDiskFreeSpaceExW impl for disk usage in system.rs - Guard Unix permissions in ssh.rs with cfg(unix) - Force foreground mode on Windows in main.rs - Set target-dir to SSD for faster builds
- Add icon.ico generated from Spacebot-iOS-Default asset (required for Windows RC) - Rename desktop binary from Spacebot to spacebot-desktop to avoid NTFS case-insensitive collision with the spacebot sidecar binary
The sidecar is launched via command.spawn() not command.execute(), so the scope must be under shell:allow-spawn for Tauri to authorize it.
In dev mode, Tauri resolves sidecars relative to the desktop executable. The sidecar lives in src-tauri/binaries/ but needs to be next to the exe in the target dir. Copy it in build.rs with timestamp comparison to only recopy when the source is newer.
Previously, sidecar crashes showed only the exit code with no details. Add onStderr handler to BundledProcessHandlers and display the last 20 stderr lines in the error message when the process exits unexpectedly.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
2 participants
Compatibility test/port of spacedriveapp#558 onto integration/upstream-prs. If core daemon changes conflict, desktop-specific fixes will be ported separately rather than replacing newer fork runtime code.