Improvements for Redux - #53
Merged
Merged
Conversation
officialMECH
added a commit
that referenced
this pull request
Sep 11, 2026
* move audio context to singleton * fix dependency resolution for mdx types * derive all editor settings from custom info data * Improvements for Redux (#53) * refactor storage middleware to strategy-based enhancers * normalize real time calculation to seconds * compute audio latency directly from audio context * add shallow apis (and explicit types) for thunk action creators * add dedicated apis for matched route selectors * simplify payloads for atomic update actions/hydrators * refactor incremental thunk action payload creators * add declarative types and implicit route accessors for listener middleware * untangle circular references for storage enhancers * consolidate beatmap entity slices with colocated history adapters * normalize reducer paths for slices * rework file structure for store modules and setup methods * improve type inference for thunk utils * move route selectors into store helpers * improve dependency injection patterns for middleware/thunks * rework singleton apis to decouple setup modules * improve type inference for thunk arguments * add shared utility for meta property action matching * make filestore source of truth for songs hydration step * fix regression in property resolution for object placement logic * move cross-slice selectors out of slice definitions * reconcile stateful thunk payloads using listener middleware * consolidate editor lifecycle logic into imperative actions * revert back to original songs hydrator (for now) * consolidate audio sample effects into imperative actions * migrate remaining cross-slice extra reducers into listener middleware effects * untangle circular references for same-site actions and selectors * fix element focus priority for prompter * fix propagations and modifier resolutions for shortcuts * fix regression in backup middleware to pull original entity state * only fire navigation for update beatmap form when active route is deleted * upgrade bsmap to v3 * bump project version * hotfix error message display for middleware * patch bsmap with upstream hotfix * rework selection by offset logic for quick select * hotfix entity state for manual save action * fix save logic to properly handle empty objects * restore new songs hydrator and reconcile editor data for pre-existing info files
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of maintenance updates to the Redux store in order to address circular dependency issues and improve some jank implementation details.
General Changes
Technical Changes
extraarguments.redux-undowas dropped in favor ofhistory-adapter, which allows for a more composable history implementation without needing to import cross-site action types for filtering.Bugfixes