Skip to content

feat(stdproject): 获取巨量智擎版标准投放项目和素材能力#81

Merged
bububa merged 1 commit into
bububa:masterfrom
flowerbin:master
Jul 18, 2026
Merged

feat(stdproject): 获取巨量智擎版标准投放项目和素材能力#81
bububa merged 1 commit into
bububa:masterfrom
flowerbin:master

Conversation

@flowerbin

Copy link
Copy Markdown
Contributor

新增标准项目列表获取、项目下素材查询接口,配套新增相关枚举定义与文档注释,完善SDK文档说明

官方文档: https://bytedance.larkoffice.com/docx/BH6zdu3j2o9hiGxr4oucedjFnGb

新增标准项目列表获取、项目下素材查询接口,配套新增相关枚举定义与文档注释,完善SDK文档说明

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the OceanEngine Marketing API's standard delivery capabilities (api/v3/stdproject), adding endpoints to list standard projects and retrieve materials, along with their associated request/response models and enums. The review feedback highlights type inconsistencies for ProductID and GameAddictionID between the StdProject and ListFilter structs, where they are defined as string in one and uint64 in the other, which could cause unmarshaling issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +41 to +42
// ProductID 产品ID
ProductID string `json:"product_id,omitempty"`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ProductID field is defined as string here, but in ListFilter (in list.go), it is defined as uint64. This type inconsistency can lead to unmarshaling errors or integration issues when mapping fields. Please make the types consistent across both structs.

Suggested change
// ProductID 产品ID
ProductID string `json:"product_id,omitempty"`
// ProductID 产品ID
ProductID uint64 `json:"product_id,omitempty"`

Comment on lines +124 to +125
// GameAddictionID 关键行为ID
GameAddictionID string `json:"game_addiction_id,omitempty"`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The GameAddictionID field is defined as string here, but in ListFilter (in list.go), it is defined as uint64. This type inconsistency can lead to unmarshaling errors or integration issues. Please make the types consistent across both structs.

Suggested change
// GameAddictionID 关键行为ID
GameAddictionID string `json:"game_addiction_id,omitempty"`
// GameAddictionID 关键行为ID
GameAddictionID uint64 `json:"game_addiction_id,omitempty"`

@bububa
bububa merged commit e3ac8d5 into bububa:master Jul 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants