Conversation
Two related gaps made a busy instance hard to use. The sentry requests carried no scope at all: the project picked in the sidebar had no effect on the exceptions list, so the grouped view — the view that makes a shared instance usable — always showed every project mixed together. The backend has had project and environment filters all along, nothing was sending them. And nothing could be narrowed by time. /api/events/preview returned the whole project (tens of megabytes of JSON on our instance) and the sentry lists paged through all of history, so reaching an error from a particular hour meant scrolling. Adds a period selector to the header (1h … 30d, All time; stored in localStorage, 24h by default) whose value is sent as ?window= alongside the project, and refetches the feed and the sentry lists when either changes. Server-side support for window/project is in buggregator/server; an older server simply ignores the extra parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related gaps made a busy instance hard to use.
Nothing was scoped by project. The sentry requests sent no parameters at all, so the project picked in the sidebar had no effect on the exceptions list: the grouped view — the view that makes a shared instance usable — always showed every project mixed together. The server has had
projectandenvironmentfilters all along; nothing was sending them.Nothing could be narrowed by time.
/api/events/previewreturned the whole project (25.8 MB in a single response on our instance) and the sentry lists paged through all of history, so reaching an error from a particular hour meant scrolling.Changes
PeriodSelectin the header: 1h / 3h / 6h / 12h / 24h / 7d / 30d / All time, stored inlocalStorage(a chosen window is a user habit, not tab state), 24h by default.?window=and the active project as?project=on every sentry request (withScopeinuse-sentry-requests) and on/api/events/preview.layout-basewatcher compares by value instead of by reference, so re-setting the same project no longer refetches the whole feed.Server-side support for
window/projectis buggregator/server#351 and #352. An older server simply ignores the extra parameters, so this is safe to ship independently — it just does nothing until the server side lands.Testing
vue-tsc --build --forceclean,eslintclean on the touched files (only the pre-existingv-htmlwarning invalue-dump.vueremains),vite build --minifysucceeds. Running in production on our instance, ≈40k events/day across 6 projects.