Integrate NightMonkey. - #323
Open
cfallin wants to merge 1 commit into
Open
Conversation
This integrates the work from bytecodealliance/firefox#2; see that PR for the full description. The main interesting/relevant integration bit is that because NightMonkey puts the compiler logic in a native binary (that runs outside the Wasm snapshot, and processes it), somewhat analogous to the `weval` tool, we need to build those binaries too. Unlike `weval`, there is not a clean and version-drift-tolerant interface between the engine and the external processing tool; rather, the compiler needs to be built from exactly the same tree as the in-Wasm-module runtime. So this repo builds those binaries now and will ship them as release artifacts alongside the Wasm runtime modules. WPT and E2E tests pass locally with the NightMonkey mode enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the work from bytecodealliance/firefox#2; see that PR for the full description.
The main interesting/relevant integration bit is that because NightMonkey puts the compiler logic in a native binary (that runs outside the Wasm snapshot, and processes it), somewhat analogous to the
wevaltool, we need to build those binaries too. Unlikeweval, there is not a clean and version-drift-tolerant interface between the engine and the external processing tool; rather, the compiler needs to be built from exactly the same tree as the in-Wasm-module runtime. So this repo builds those binaries now and will ship them as release artifacts alongside the Wasm runtime modules.WPT and E2E tests pass locally with the NightMonkey mode enabled.
This will require the above-linked PR to merge first, then I'll retarget the commit hash here to point to the merged commit. After this merges, I'll integrate in ComponentizeJS.