Accessor tests - #1733
Draft
bvisness wants to merge 5 commits into
Draft
Accessor tests#1733bvisness wants to merge 5 commits into
bvisness wants to merge 5 commits into
Conversation
I spent some time confused by the fact that obviously non-wasip1 modules were being fed through a function explicitly named for wasip1.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because wasmtime has some kind of bug, these tests originally from #1726 are in a separate PR. Tests are provided for C, C++, and Rust since those are the three languages supported by #1726. All three use the same WIT and perform the same sequence of get/set operations.
Also contains a drive-by rename of
convert_p1_to_componentsince it handles more than just wasip1.Currently this PR changes CI to run the dev version of wasmtime, since that's what we had originally discussed, but I can change it back to a pinned version once a version without the bug is published.