Change stream methods to require &mut - #146
Open
adamrk wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Note: this PR should be on top of #142, but I can't seem to select that branch as the target in the PR (I guess because it's from my fork of the repo?). |
Contributor
Author
|
Looks like the test failure is the same one that should be fixed by #143. |
adamrk
force-pushed
the
abk/shared-ref-changes
branch
2 times, most recently
from
September 3, 2026 14:06
2045a63 to
22c1ffa
Compare
adamrk
force-pushed
the
abk/shared-ref-changes
branch
from
September 3, 2026 14:26
22c1ffa to
443ef72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #142
The existing stream methods that read and write through
&references won't work withp3streams, so this makes the breaking change of requiring&mutwhen reading and writing. This PR contains all the expected breaking changes from addingp3support.Addresses #145