fix wrong error raised when private key is missing or invalid - #80
Open
shashfrankenstien wants to merge 4 commits into
Open
fix wrong error raised when private key is missing or invalid#80shashfrankenstien wants to merge 4 commits into
shashfrankenstien wants to merge 4 commits into
Conversation
…otFoundError logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
Connectionclass, if the private key file is not inkey_types, or if the file path provided doesn't exist, it raisesThis is because
key.from_private_key_fileis called in afinallyblock that will execute regardless of whether the try succeeds or fails. The correct branch to use iselse.Additionally,
self._transport.auth_publickeyandself._transport.auth_passwordwere being called even whenpasswordand/orprivate_keyinputs were not strings. This PR fixes this and raisesCredentialExceptionAdded required tests!