Repository navigation
Conversation
|
Hi maintainers, gentle ping on this PR. CI is all green. Would appreciate a review when you have time. |
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
|
@blackboxsw, this PR is still relevant — CI is all green and ready for review. Could you please take a look when you have time? Thanks! |
nryanl
left a comment
There was a problem hiding this comment.
Welcome @debianyu !
A few things:
-
Since you are a first time contributor, could you start by signing the CLA?
-
If you have cloud-init logs from kylin, could you attach those to your submission?
-
Don't forget to add kylin to the list of supported distros in our documentation. You can find that list in
doc/rtd/reference/availability.rst. -
I left a comment regarding a minor formatting issue.
| class Distro(rhel.Distro): | ||
| def __init__(self, name, cfg, paths): | ||
| super(Distro, self).__init__(name, cfg, paths) | ||
| self.osfamily = "kylin" No newline at end of file |
There was a problem hiding this comment.
There should be a newline at the end of this file. tox -e do_format should catch this.
Kylin Linux Advanced Server is a RHEL-based distribution that uses the same DNF/yum package management, NetworkManager, and systemd tooling as other RHEL-family distributions. This adds it as a recognized distro following the pattern of openeuler, OpenCloudOS and TencentOS. Signed-off-by: YuPeng <yupeng@kylinos.cn>
4fed265 to
511ac7d
Compare
|
@nryanl Thanks for the review! All items addressed:
os-release: tail -50 /var/log/cloud-init.log |
What this does
Adds Kylin Linux Advanced Server as a recognized distro in cloud-init,
following the pattern established by openeuler, OpenCloudOS and
TencentOS.
Kylin is a RHEL-based Linux distribution that uses DNF/yum package
management, NetworkManager for networking, and systemd for service
management — the same tooling as other RHEL-family distros already
supported by cloud-init.
Scope
cloudinit/distros/kylin.py), 44 insertions, 9 deletionsrhel.Distroand setsosfamily = "kylin"is_rheltemplate set,gecosdict ("kylin": "Cloud User"),and
usernamesdict ("kylin": "cloud-user") incloud.cfg.tmpl. Groupsand shells use existing
is_rhel/ default fallbacks.cc_ntp, cc_resolv_conf, cc_yum_add_repo, cc_spacewalk
Testing
OS_RELEASE_KYLINtest data added for os-release parsingtest_get_linux_kylinverifies correct distro name extractionTestGetVariantentry added for kylin variant mappingtox -e py3)