Repository navigation
feat(pytest-plugin): dep extra to track minimum pytest version - #498
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Narrow the import exception handling and add coverage for the missing-pytest fallback.
2 open findings
What changed in this PR
Adds an optional craft-cli[pytest] dependency extra and improves missing-pytest diagnostics.
Changes:
- Declares
pytest>=8.4as an optional dependency. - Updates the lockfile and changelog.
- Adds import-time error handling for missing
pytest.
| File | Summary |
|---|---|
uv.lock |
Records the new optional dependency. |
pyproject.toml |
Defines the pytest extra. |
docs/changelog.rst |
Documents the dependency and error behavior. |
craft_cli/pytest_plugin.py |
Adds pytest import handling; the handler should be narrowed and covered by an isolated test. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bepri
added this pull request to stack #500
October 9, 2026 15:28
lengau
approved these changes
Oct 9, 2026
mr-cal
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


make lint && make test?Adds a dependency group to help downstream users with pinning to an appropriate pytest version.
This wasn't a dependency at all in the past, so downstream users just had to coincidentally have pytest already in their env in order to use the plugin.