Repository navigation
feat(pytest-plugin): easier assertions on error contents - #499
Merged
Merged
Conversation
bepri
added this pull request to stack #500
October 9, 2026 15:28
lengau
approved these changes
Oct 9, 2026
lengau
reviewed
Oct 9, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Regenerate and commit uv.lock so frozen documentation builds remain valid.
1 open finding
What changed in this PR
Adds raises_craft_error to simplify assertions on CraftError contents.
Changes:
- Implements the new pytest helper.
- Adds comprehensive tests.
- Updates pytest requirements and changelog documentation.
| File | Summary |
|---|---|
tests/test_pytest_plugin.py |
Tests helper matching and failure behavior. |
pyproject.toml |
Updates the pytest requirement. |
docs/changelog.rst |
Documents the new feature. |
craft_cli/pytest_plugin.py |
Implements the assertion helper. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lengau
force-pushed
the
work/pytest-error-assertion
branch
from
October 9, 2026 16:04
0cb3c64 to
413607e
Compare
mr-cal
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

make lint && make test?Adds a new function to the pytest plugin to make testing CraftErrors easier. Now, instead of this:
you can just do:
This should be a drop-in replacement for any block that already uses
pytest.raises().Stack created with GitHub Stacks CLI • Give Feedback 💬