Skip to content

fix(azure): resolve mypy call-overload error on NIC creation #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackboxsw merged 2 commits into from
Sep 17, 2026
Merged

fix(azure): resolve mypy call-overload error on NIC creation #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f2739
fix(azure): resolve mypy call-overload error on NIC creation
8rulerstar Sep 16, 2026
4dd757e
chore: bump version to 1!11.1.8
8rulerstar Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1!11.1.7
1!11.1.8
5 changes: 4 additions & 1 deletion pycloudlib/azure/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ def add_network_interface(self, **kwargs) -> str:
"tags": None,
}
nic_name = f"{self.name}-nic-{us}"
nic_poller = self._network_client.network_interfaces.begin_create_or_update(
# The SDK types `parameters` as a `NetworkInterface` model (or raw bytes),
# but it also accepts the ARM-shaped dict we build above, which is what the
# rest of this module passes. Ignore the narrower overload, not the call.
nic_poller = self._network_client.network_interfaces.begin_create_or_update( # type: ignore[call-overload]
self._instance["rg_name"],
nic_name,
default_config,
Expand Down