Fix chardet import for compatibility with chardet >= 0.7.0 - #1215
Open
jellyfishing2346 wants to merge 1 commit into
Open
Fix chardet import for compatibility with chardet >= 0.7.0#1215jellyfishing2346 wants to merge 1 commit into
jellyfishing2346 wants to merge 1 commit into
Conversation
Changed from 'from chardet.universaldetector import UniversalDetector' to 'from chardet import UniversalDetector' to support chardet 0.7.0+ which changed their import structure. Fixes capitalone#1204
|
|
Author
|
Hi @leos, I was wondering if you happen to have any feedback on this PR. |
Contributor
|
@jellyfishing2346 does this still support backwards compatibility? If reqs don't require the new version then this could break older versions. |
Author
|
@JGSweets it doesn’t. |
Contributor
|
@jellyfishing2346 do you know if they ever resolved this issue of changing the default likelihood: Also, unsure if they resolved their license issue for 7.0.0+ |
Author
|
@JGSweets I don't believe I know if they did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed from 'from chardet.universaldetector import UniversalDetector' to 'from chardet import UniversalDetector' to support chardet 0.7.0+ which changed their import structure.
Fixes #1204