Skip to content

refactor: replace cast() with isinstance assertions in reports - #1222

Open
ovodela wants to merge 19 commits into
capitalone:devfrom
capitalone-contributions:refactor-remove-cast-reports
Open

refactor: replace cast() with isinstance assertions in reports#1222
ovodela wants to merge 19 commits into
capitalone:devfrom
capitalone-contributions:refactor-remove-cast-reports

Conversation

@ovodela

@ovodela ovodela commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • Replaces all 4 cast() calls in dataprofiler/reports/graphs.py with assert isinstance() or assert is not None checks
  • Provides both static type safety (mypy narrowing) and runtime validation instead of unchecked casts
  • Removes unused Union and cast imports from typing
  • The cast(F, new_f) in utils.py is intentionally retained

Test plan

  • All existing test_graphs.py tests pass (16 tests)
  • mypy reports no new type errors

Addresses #720

taylorfturner and others added 19 commits June 14, 2024 13:11
@taylorfturner @JGSweets
@gliptak @JamesSchadt
staging/main/0.12.0 (capitalone#1145)
4545841 
* refactor: Upgrade the models to use keras 3.0 (capitalone#1138)

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* pre-commit fix (capitalone#1122)

* Bug fix for float precision calculation using categorical data with trailing zeros. (capitalone#1125)

* Revert "Bug fix for float precision calculation using categorical data with t…" (capitalone#1133)

This reverts commit d3159bd.

* refactor: move layers outside of class

* refactor: update model to keras 3.0

* fix: manifest

* fix: bugs in compile and train

* fix: bug in load_from_library

* fix: bugs in CharCNN

* refactor: loading tf model labeler

* fix: bug in data_labeler identification

* fix: update model to use proper softmax layer names

* fix: formatting

* fix: remove unused line

* refactor: drop support for 3.8

* fix: comments

* fix: comment

---------

Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>

* Fix Tox (capitalone#1143)

* tox new

* update

* update

* update

* update

* update

* update

* update

* update tox.ini

* update

* update

* remove docs

* empty retrigger

* update (capitalone#1146)

* bump version

* update 3.11

* remove dist/

---------

Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>
Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>
@armaan-dhillon @JGSweets
@gliptak @taylorfturner @JamesSchadt @micdavis
Staging release 0.13.0 (capitalone#1165) (capitalone#1166)
50da93f 
* refactor: Upgrade the models to use keras 3.0 (capitalone#1138)

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------



* pre-commit fix (capitalone#1122)

* Bug fix for float precision calculation using categorical data with trailing zeros. (capitalone#1125)

* Revert "Bug fix for float precision calculation using categorical data with t…" (capitalone#1133)

This reverts commit d3159bd.

* refactor: move layers outside of class

* refactor: update model to keras 3.0

* fix: manifest

* fix: bugs in compile and train

* fix: bug in load_from_library

* fix: bugs in CharCNN

* refactor: loading tf model labeler

* fix: bug in data_labeler identification

* fix: update model to use proper softmax layer names

* fix: formatting

* fix: remove unused line

* refactor: drop support for 3.8

* fix: comments

* fix: comment

---------





* Fix Tox (capitalone#1143)

* tox new

* update

* update

* update

* update

* update

* update

* update

* update tox.ini

* update

* update

* remove docs

* empty retrigger

* update (capitalone#1146)

* Add Python 3.11 to GHA (capitalone#1090)

* add downloads tile (capitalone#1085)

* Add Python 3.11 to GHA

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------



* Update dask modules

* Install dask dataframe

* Update dask modules in precommit

* Correct copy/paste error

* Try again to clear Unicode

* Rolled back pre-commit dask version

* Add py311 to tox

* Bump dask to 2024.4.1

* Bump python-snappy 0.7.1

* Rewrite labeler test

* Correct isort

* Satisfy black

* And flake8

* Synced with requirements

---------



* [Vuln Fix]: Resolve mend vulnerabilities related to requests. (capitalone#1162)

* resolved check-manifest issue

* updating keras version pin to <=3.4.0

* adding comment in requirements.txt to trigger mend check

---------



---------

Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>
Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>
Co-authored-by: Michael Davis <36012613+micdavis@users.noreply.github.com>
@shania-m
chore: update mypy dependencies (capitalone#1171)
c0f86fb
@shania-m
chore: refactor release process (capitalone#1170)
48d0fd5
@shania-m
chore: Update publish-package.yml (capitalone#1172)
aafeef6
@shania-m
gh pages update (capitalone#1173)
ed8188a 
* chore: create publish-docs.yml

* brought in docs directory
@shania-m
Update gh-pages workflows (capitalone#1174)
09c2062 
* chore: update workflow to properly install pandoc
* chore: update build to build to a LATEST directory
@shania-m
Remove Versions from Intro page (capitalone#1175)
9919af4
@shania-m
chore: Workflow permissions (capitalone#1182)
5a1ee0a 
* chore: permissions for publish-docs
@mhmotamedi
docs: add architecture.rst for algorithm rationale, testing, versioni…
1a84430 
…ng (capitalone#1181)

* docs: add architecture.rst for algorithm rationale, testing, and versioning details

* docs: remove manual table of contents from architecture.rst for Furo compatibility and edit  content
@ryanSoley
ops: drop python 3.9 & resolve vulns (capitalone#1192)
c035a05 
* ops: drop python 3.9 (EOL)
* ops: add whitesource config
* fix: don't add python 3.12 yet
* ops: add whitesource config to MANIFEST
* fix: remove `--forked` to fix coverage
* fix: remove tests that depend on `--forked`
* ops: update vulnerable libraries
@ryanSoley
ops: properly configure whitesource (capitalone#1195)
ebb7ee1 
* ops: properly configure whitesource
* ops: add whitesource config to MANIFEST
@ryanSoley
fix: use core config (capitalone#1198)
5a381d5
@JGSweets
fix: limit chardet < 7.0.0 and pandas <3.0.0 (capitalone#1205)
07298a2 
* Update data_utils.py

* revert: chardet import

* fix: chardet requirements

* fix: pandas req limit

* fix: tests with approx

* fix: missing test fix
@JGSweets
refactor: move from deprecated pkg_resources (capitalone#1202)
52b5275 
* refactor: move from deprecated pkg_resources

* fix: base str traversal

* fix: to use func

* fix: add missing change

* refactor: move from data_files to package_files

* refactor: resources to be in package

* fix: utils

* fix: path error

* fix: str required

* fix: tests bc of almost

* feat: refactor to pass in a path or string or None

* fix: import for older versions

* fix: Tranversable must be done at runtime

* fix: add test

* fix: accidentally duplicated test on rebase

* fix: remove pass
@JGSweets
Update keras, tf and new model usage, numpy 2.0 updates (capitalone#1206
75f0ef8 
)

* refactor: move from deprecated pkg_resources

* fix: to use func

* fix: add missing change

* refactor: resources to be in package

* fix: tests bc of almost

* feat: refactor to pass in a path or string or None

* fix: import for older versions

* fix: Tranversable must be done at runtime

* refactor: keras reqs and others

* refactor: losses for keras and tests

* fix: remove unneeded global

* fix: accidentally duplicated test on rebase

* fix: rebase duplicates

* fix: keras reqs

* refactor: update to be more than 3.4.0 for keras

* refactor: numpy2 and mypy

* fix: mypy 3.10

* fix: bugs

* fix: float

* refactor: for hist fix too

* fix: issue with none in hist

* fix: remove comment

* refactor: to still utilize dict mapping for losses

* fix: int pre-commit

* fix: train labeling

* refactor notes, reqs, and change log

* fix: pre-commit

* refactor: add unit tests validating usage of the old load format
@JGSweets
refactor: add py3.12 and py3.13 to tests (capitalone#1212)
4b5ab37 
* refactor: add py3.12 and py3.13 to tests

* fix: commit setting

* fix: mypy issues

* fix: typing

* refactor: update mypy

* fix: issues with mypy

* fix: cnn typing

* fix: typing again

* fix: numpy typing

* fix: typing more

* fix: typing more

* fix: req issue

* fix: test failure

* fix: bug in test

* fix: assertalmostequal
@shania-m
Release 0.14.0 (capitalone#1220)
1f14aa1 
* docs: add 0.14.0 changelog

* chore: trigger checks
@ovodela
refactor: replace cast() with isinstance assertions in reports/graphs.py
87d516d 
Replace cast() with assert isinstance() for both static type safety
and runtime validation instead of unchecked casts.

Addresses capitalone#720
@ovodela
ovodela requested a review from a team as a code owner September 9, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ovodela @taylorfturner @armaan-dhillon @shania-m @mhmotamedi @ryanSoley @JGSweets