Replace MSVC-only _ASSERTE with CCP_ASSERT

[TrueBrain]

Summary

This repository, and even the file in question, uses CCP_ASSERT everywhere except for these few places.

Although they strictly seen do slightly different things, I assume _ASSERTE is just a left-over, and the intention is CCP_ASSERT.

AI assistance disclosure

Claude detected the issue; I fixed the issue.

Type of change

• Bug fix
• New feature
• Refactor / cleanup (no behaviour change)
• Documentation
• Build, CI, or tooling
• Breaking change (public API or ABI)
• Other (describe below)

Linked issue (optional)

What changed

• Less MSVC-ism.

Testing

This file isn't included locally. So there is nothing to test as such. You just can't compile the header on MacOS / Linux.

Platforms tested

• Windows
• macOS
• Linux

Screenshots / captures

Checklist

• I've read CONTRIBUTING.md.
• My commits follow the commit-message style described there.
• I've added or updated tests where it made sense.
• I've updated docs / inline API comments for any behaviour change.
• My CLA / ICLA is signed (the bot will let you know if it isn't).

---

Full disclosure: I am employed by Fenris Creations, although I have no involvement with the Carbon project. I work on this in my free time under my own name.

[CCP-Aporia]

Good catch, I don't see why _ASSERTE should be used here. If anything, those asserts would be missed in non-debug builds, while we want assertions to fire in all configurations except Release.