Enable vcpkg manifest features based on CMake options - #42
Open
TrueBrain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, vcpkg installs all dependencies. Including Python3, even if you don't build the documentation. This is mostly a problem for targets (like Emscripten), that don't allow for building Python3. But this repository doesn't actually need with its default options.
Instead, use vcpkg manifest features like some other repositories already do (like
meshandresources):option()s beforeproject()VCPKG_MANIFEST_FEATURESI assumed
if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)was a left-over guard from the migration to GitHub, and actually has no function anymore. Do let me know if that wasn't the case.AI assistance disclosure
Claude did a lot of triage what
if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)was actually about. Otherwise: noneType of change
Linked issue (optional)
What changed
option()Testing
(no more Python3 in default setup)
Platforms tested
Screenshots / captures
Checklist
Full disclosure: I am employed by Fenris Creations, although I have no involvement with the Carbon project. I work on this in my free time under my own name.