Skip to content

fix: remove harmful process.chdir() in OpenCodeService #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ideabib wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove harmful process.chdir() in OpenCodeService #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/OpenCodeService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,8 @@ export class OpenCodeService {

this.isInitializing = true;

const prevCwd = process.cwd();
const shouldChdir =
Boolean(workspaceRoot) && fs.existsSync(workspaceRoot as string);

if (shouldChdir) {
this.workspaceDir = workspaceRoot as string;
if (workspaceRoot && fs.existsSync(workspaceRoot)) {
this.workspaceDir = workspaceRoot;
}

try {
Expand All @@ -55,10 +51,6 @@ export class OpenCodeService {

this.ensureOpencodeCliAvailable();

if (shouldChdir) {
process.chdir(workspaceRoot as string);
}

logger.info("Starting OpenCode server...");

this.opencode = await createOpencode({
Expand All @@ -73,13 +65,6 @@ export class OpenCodeService {
await this.showStartupError(error);
throw error;
} finally {
if (shouldChdir) {
try {
process.chdir(prevCwd);
} catch (e) {
getLogger().warn("Failed to restore working directory", e);
}
}
this.isInitializing = false;
}
}
Expand Down