ci: move pnpm onlyBuiltDependencies to pnpm-workspace.yaml - #5
Merged
Merged
Conversation
pnpm 10 stopped reading settings from the "pnpm" field in package.json — the previous fix was silently ignored with a warning. Settings now live in pnpm-workspace.yaml. Also run pnpm install in the Test job so this class of regression fails on every push/PR instead of only on tag pushes.
pnpm 10 added strict rejection of dependencies with unallowlisted build scripts (esbuild's postinstall trips it). The allowlist setting then moved twice — out of package.json 'pnpm' field (10) and into pnpm-workspace.yaml (11), but the workspace file isn't being honored in our single-package layout. Pin to pnpm 9 until the config story settles. Drops the unused elo-tauri/pnpm-workspace.yaml.
Other actions already on their latest major: actions/checkout@v6 actions/setup-node@v6 actions/upload-artifact@v7 actions/download-artifact@v8 Swatinem/rust-cache@v2 dtolnay/rust-toolchain@nightly (channel pin, not a version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 10 stopped reading the
pnpmfield inpackage.json, so the previous fix was silently ignored —[ERR_PNPM_IGNORED_BUILDS]is back on the v0.3.0 retag.Moves the allowlist to
elo-tauri/pnpm-workspace.yaml(the new home in pnpm 10).Also runs
pnpm install --frozen-lockfilein the Test job so frontend-install regressions fail on every push/PR rather than only on tag pushes.