Repository navigation
fix(npmjs): laggy packument gauge always reads zero - #1936
Merged
cdklabs-automation merged 1 commit intoSep 23, 2026
Merged
Conversation
The LaggyPackuments gauge was emitted at the end of the retry phase, which is its trough: recoveries have just been processed and the scan has not recorded new expectations yet. On the Gamma deployment the gauge read a constant 0 while the state file tracked 2-3 laggy packuments. It is now emitted at the end of the run. Also adds the LaggyPackumentsRecovered metric to the Feed Reliability dashboard widget; it was missing even though it is the most active signal on that widget (12 recoveries in a single run on Gamma).
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
cdklabs-automation
enabled auto-merge
September 23, 2026 10:58
rix0rrr
approved these changes
Sep 23, 2026
cdklabs-automation
deleted the
mrgrain/fix/npmjs/feed-reliability-widget
branch
September 23, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While verifying the Gamma deployment of #1935, I noticed the Feed Reliability widget shows nothing useful.
The
LaggyPackumentsgauge always reads 0, even though the state file was tracking 2-3 laggy packuments at the time. We emitted the metric at the end of the retry phase. At that point recoveries are already processed and the scan hasn't recorded new expectations yet, so the count is always 0. The gauge is now emitted at the end of the run instead.LaggyPackumentsRecoveredwas missing from the widget completely. Turns out it's the busiest metric of the bunch: Gamma had 12 recoveries in a single run. It's now on the widget.Extended the existing tests to check the gauge values: 1 after recording an expectation, 0 after a recovery.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license