Update pangu filename and widen fileMap - #2183
Open
vinta wants to merge 3 commits into
Open
Conversation
vinta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm the author of pangu.
filename: the current defaultpangu.min.jsis the minified ESM build — it cannot run from a classic<script src>tag. The new defaultbrowser/pangu.umd.min.jsis the self-contained UMD build (globalpangu), which is what script-tag users need.fileMap: since pangu 8.1.0, the ESMdist/browser/pangu.jsimports a sibling module outsidedist/browser(../shared/index.js, later../shared-<hash>.js), so under the oldbasePath: dist/browserthat import would 404 on cdnjs. Widening tobasePath: distwith globs for the browser and shared runtime JS + sourcemaps keeps the module build resolvable regardless of the bundler's chunk layout. The Node.js build (dist/node*) and TypeScript declarations (*.d.ts) are intentionally excluded — they aren't useful from a CDN.Note: hosted paths for new versions gain a
browser/prefix (e.g./ajax/libs/pangu/<version>/browser/pangu.umd.min.js) — intentional.