Respect composed adapter for unregistered structs#1384
Open
lopster568 wants to merge 1 commit into
Open
Conversation
nativeTypeProvider.NativeToValue routed every struct-kind value to newNativeObject, regardless of whether the type was registered via ext.NativeTypes. Every other method on the provider checks the nativeTypes registry first and falls back to the composed base adapter when a type is not registered; NativeToValue was the exception, so a custom adapter added with cel.CustomTypeAdapter never saw unregistered structs it wanted to convert itself. Mirror the registry check from NewValue: only wrap registered struct types as native objects, and delegate the rest to the base adapter. Fixes cel-expr#1343
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TristonianJones
requested changes
Jul 24, 2026
TristonianJones
left a comment
TristonianJones
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! I just have one minor code maintenance request, but otherwise LGTM
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Jul 25, 2026
Collaborator
|
@lopster568 I'm just waiting on the CLA check before I can accept the contribution. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nativeTypeProvider.NativeToValuewrapped every struct-kind value as a native object regardless of whether the type was registered throughext.NativeTypes. Every other method on the provider checks thenativeTypesregistry first and delegates unregistered types to the composed base provider or adapter;NativeToValuewas the exception, so acel.CustomTypeAdaptercomposed alongsideext.NativeTypesnever saw struct values it should convert itself.This mirrors the registry check from
NewValue: registered struct types are still wrapped as native objects, and unregistered ones now reach the base adapter. This is the fix proposed in the issue and changes behavior for unregistered structs.Fixes #1343