Updates to type unification with parameterized types#1385
Open
TristonianJones wants to merge 1 commit into
Open
Updates to type unification with parameterized types#1385TristonianJones wants to merge 1 commit into
TristonianJones wants to merge 1 commit into
Conversation
jnthntatum
approved these changes
Jul 25, 2026
| outType: types.NewListType(types.NewNullableType(types.IntType)), | ||
| }, | ||
| { | ||
| in: `[1, null]`, |
Collaborator
There was a problem hiding this comment.
These are a bit interesting, do you think we should automatically promote to a union type based on component elements, or require that one of the elements already inferred to be a union? (maybe less interesting for just nullables right now, but becomes more interesting if we add a JSON value type union or something like any of from JSON schema and have to decide if we keep a set of type union candidates or allow arbitrary ones).
| outType: types.NewListType(types.NewNullableType(types.IntType)), | ||
| }, | ||
| { | ||
| in: `[null_int, null, 1]`, |
Collaborator
There was a problem hiding this comment.
May want an explicit test to check that different nullables don't coalesce [m.string_wrapper, null, m.int64_wrapper] -> list(dyn)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses type unification issues identified in conformance tests.
Closes #1312