feat!: remove the legacy Timeline - #1064
Merged
lcottercertinia merged 2 commits intoSep 18, 2026
Merged
Conversation
The pixi.js Timeline replaced the canvas 2D chart in 1.20.0, which stayed behind lana.timeline.legacy as a temporary fallback. 1.22 deprecates it; this drops it. With one renderer left, a legend chip always stands for one category, so TimelineKeyEntry holds a category instead of a label and a group of them. BREAKING CHANGE: lana.timeline.legacy and lana.timeline.colors are removed. Theme the Timeline with lana.timeline.activeTheme and lana.timeline.customThemes.
lcottercertinia
previously approved these changes
Sep 18, 2026
lcottercertinia
marked this pull request as ready for review
September 18, 2026 16:43
…meline # Conflicts: # lana-docs/docs/docs/settings.mdx # lana/package.json
lcottercertinia
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Removes the legacy Timeline. The pixi.js flame chart replaced the canvas 2D chart in 1.20.0, which stayed behind
lana.timeline.legacyas a temporary fallback — its own description said it would go in a future release. 1.22 deprecates it; this drops it.Targets 1.24, the removal release. Draft until then.
🛠️ Changes made
features/timeline/services/Timeline.ts), its<timeline-legacy>host, and the test that covered only its find listeners.lana.timeline.legacyandlana.timeline.colorssettings from the schema,ConfigandLanaSettings.TimelineView: the renderer choice, the palette fork, and the two toolbar buttons legacy used to hide. The skeleton still waits for settings, now on asettingsReadyflag.TimelineKeyEntryholds acategoryinstead of alabelplus a group of them. That retires the category folding intoTimelineKeysand the comma-joineddata-category.## [Unreleased]section for 1.24, above the one that ships as 1.22. Deliberate: it keeps this entry off the lines the version stamp will touch. The two collapse into one when 1.22 is tagged.🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
No visual change to the Timeline. The Settings pane loses two entries under Apex Log Analyzer → Timeline.
🔗 Related Issues
related #
✅ Tests added?
A removal. The legacy-only suites are deleted; the rest are rewritten onto the one-category legend shape.
pnpm test: 187 suites, 2610 tests, all pass.pnpm lint: 0 errors.pnpm build: clean.📚 Docs updated?
Anything else we need to know? [optional]
Two open questions for you, neither blocking:
lana.timeline.legacyorlana.timeline.colorskeeps a dead key insettings.json, which VS Code flags as an unknown setting. AdeprecationMessageon both keys for one release would soften that — one property each inpackage.jsonif you want it.package.jsonschema,Configinlana/, andLanaSettingsinlog-viewer/. Removing one boolean meant editing all three, and nothing would have caught a miss. Worth a parity test, but not in a removal PR.