Repository navigation
Conversation
The reverse DNS expert bot has a self-test that checks that an IPv6 address without a PTR record does not insert a spurious hostname. However, the address used in the test is a public routable one, which recently gained a PTR record, which makes the test fail. Switch to an address reserved for documentation, which is more likely to keep not having a PTR record. Closes certtools#2725
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reverse DNS expert bot has a self-test that checks that an IPv6 address without a PTR record does not insert a spurious hostname. However, the address used in the test is a public routable one, which recently gained a PTR record, which makes the test fail.
Switch to an address reserved for documentation, which is more likely to keep not having a PTR record.
Closes #2725