Repository navigation
Conversation
… timestamps Assisted-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A MISP search can return an event with matching attributes or tags but no intelmq_event object. _update_misp_event() indexes the empty object list and raises IndexError, preventing the output bot from processing later results or acknowledging the message.
Return without updating such an event. Preserve the existing first-object matching and timestamp update behavior. Replace the test stub with five local regression and control cases, including a process call with an unrelated result followed by a matching event, and document the fix in the changelog.
Validation: two new cases fail with IndexError and three controls pass on unmodified develop. After the fix, the MISP, message and harmonization suites report 192 passed and 17 skipped on Python 3.12.14. Project source pycodestyle, test-file pycodestyle, REUSE license validation and git diff --check pass.
A full basic-suite run reports 355 passed, 336 skipped, one failure and 523 setup errors. The same run against a clean develop worktree reports 350 passed, 336 skipped and the identical 524 failing/error test identifiers: the controller refuses to run as root, and bot fixtures require a local Redis service unavailable here. The five additional passing tests account for the difference. Service-backed and live MISP integration tests require the upstream CI environment.
Prepared with assistance from OpenAI Codex; behavior, style, licensing and regression results were verified locally.