ci: Add support for OIDC - #2053
Merged
Merged
Conversation
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 13:29
3b5aa58 to
789f6cb
Compare
This commit adds support for OIDC, replacing long-lived tokens. Quay.io has been configured accordingly. The token expires after one hour, so it is minted after each build rather than once at the start of the job. The robot account names are read from the QUAY_ROBOT_CI and QUAY_ROBOT_RELEASE variables, defined on the GitHub environments the jobs pin rather than at repository or organisation level, so the value a job receives is the one belonging to its environment. The environment name also forms the OIDC subject that the robot is configured to trust, so renaming an environment breaks the login. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 14:47
789f6cb to
5983dc5
Compare
sayboras
reviewed
Sep 26, 2026
sayboras
left a comment
sayboras
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for your kind help, just a note that we don't have ariane enabled for this repo, so the changes are actually not verified due to pull request target settings.
Member
Author
|
Tested with a temporary DO NOT MERGE commit that switches build-envoy-image-ci.yaml to pull_request: https://github.com/cilium/proxy/actions/runs/36422919990. The run got the robot token through OIDC and pushed quay.io/cilium/cilium-envoy-dev:a4198916e1ef6f0246622b3d000070f498450615@sha256:20b1f2febe3187d36ea6e1ae5084f0d2e5aaae60fa5a849f73ac97483958d6e7, the digest cosign signed and the SBOM is attached to. The builder image already existed, so its OIDC login step was skipped. |
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 28, 2026 12:51
a419891 to
5983dc5
Compare
sayboras
marked this pull request as ready for review
September 28, 2026 13:48
sayboras
reviewed
Sep 28, 2026
sayboras
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for OIDC, replacing long-lived tokens. Quay.io
has been configured accordingly.
The token expires after one hour, so it is minted after each build
rather than once at the start of the job.
The robot account names are read from the QUAY_ROBOT_CI and
QUAY_ROBOT_RELEASE variables, defined on the GitHub environments the
jobs pin rather than at repository or organisation level, so the value a
job receives is the one belonging to its environment. The environment
name also forms the OIDC subject that the robot is configured to trust,
so renaming an environment breaks the login.