Conversation
Upstream connection pools are shared between downstream connections, so the source address socket option of one downstream connection is also used to open upstream connections for requests of other downstream connections. The option decided whether to skip the source address based on the destination filter state, which holds the destination of the latest request of the downstream connection that created the option, not the destination of the upstream connection being opened. As a result, north/south L7 LB connections to remote pods could be opened without the Ingress source address and get dropped by policy at the destination node, and connections to local pods could be opened with it. Use the remote address of the upstream socket instead, which is always set to the selected upstream host before the socket is bound. Signed-off-by: Matvei Antipov <matvei.antipov@payrails.com>
Member
|
Hi, please make sure to review the Guide for Submitting a Pull Request and |
joestringer
marked this pull request as draft
September 26, 2026 17:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2040. The decision on whether to skip the Ingress IP binding is now made from the upstream socket's remote address, instead of the destination filter state of the downstream connection that created the shared upstream connection pool.
I covered the issue with a test and the fix makes this test pass.