Conversation
With ADS the policy map is pinned for the stream lifetime, but its NPDS start target is only added to the init manager of the listener that created the map. If that listener is rejected after its listener filters are built, the target never runs and NPDS is never requested. The agent then waits forever for NPDS ACKs and new pods on the node fail CNI ADD. Add the start target to each listener that reuses the map until NPDS has started, and make start() a no-op on a started subscription. Fixes: 0b027ba ("envoy: keep ADS policy maps alive") Relates: cilium/cilium#49056 Signed-off-by: Jimmy Herrera <4251126+arruko@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1982 the policy map is pinned for the ADS stream lifetime, but its NPDS start target is only registered with the listener that created the map. If that listener is rejected, NPDS is never requested, so the agent waits forever for NPDS ACKs and new pods on the node fail CNI ADD.
Add the start target to each listener that reuses the map until NPDS has started, and make start() a no-op once started. The new integration test sends two rejected listeners and checks that NPDS starts with the next one.
Fix for cilium/cilium#49056
Please backport to v1.37 (used by Cilium v1.20).