Conversation
🦋 Changeset detectedLatest commit: 17876fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…on-overlay elements Guards against the drop-animation effect not firing in sync with the dragend event, and makes cleanup idempotent since it can now be triggered from two separate listeners.
@dnd-kit/abstract
@dnd-kit/collision
@dnd-kit/dom
@dnd-kit/geometry
@dnd-kit/helpers
@dnd-kit/react
@dnd-kit/solid
@dnd-kit/state
@dnd-kit/svelte
@dnd-kit/vue
commit: |
FaroKlandee
added a commit
to FaroKlandee/Project-noBackLog
that referenced
this pull request
Aug 6, 2026
Two independent bugs surfaced during cross-list drag testing: - Same-list reorders duplicated the dragged card: CardItem passed group: card.listId (a number) into useSortable, but @dnd-kit/helpers's move() compares group against cardsByList's Object.keys with !==, and object keys are always strings. Coerced to String(card.listId). - Cross-list drops threw "NotFoundError: Failed to execute 'removeChild' on 'Node'": an upstream bug in @dnd-kit/dom's OptimisticSortingPlugin physically relocates the dragged DOM node on every dragover as a live preview, and never restores it on a successful drop, so React's reconciler and the live DOM disagree about the node's parent on the next render. Backported the fix from the still-unmerged upstream PR (clauderic/dnd-kit#2102) via patch-package so it survives npm install. Also added a DragOverlay (with minimal CardPreview/ListColumnPreview clones) so dnd-kit's drag feedback targets a React-owned node instead of the real card/column element, and a .claude/launch.json for running both dev servers locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues #1747 and #1780 where the application crashes with DOMException: Node.removeChild: The node to be removed is not a child of this node (or NotFoundError on Vite/Rollup) when dragging sortable items or elements across different groups/containers.
Cause of the Issue
During dragging operations, OptimisticSortingPlugin and Feedback directly manipulate the DOM tree (e.g., using insertAdjacentElement to reorder nodes, or appending dragging elements to a popover/overlay root element). When a drag operation ends, the framework (React/Solid/Vue/Svelte) updates state and reconciles the DOM tree. However, because the DOM structure was altered directly outside the framework, the virtual DOM reconciliation gets out of sync, leading to errors like parent.removeChild failing to find the target element.
Solution
This completely avoids any DOM reconciliation mismatches and resolves the crashes across all list component structures.