chore(ui,shared,localizations): Handle expired status for organization domain#9000
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ef0890b The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
d2b3e68 to
a35cc5e
Compare
a35cc5e to
c56b009
Compare
c56b009 to
84fb3e9
Compare
API Changes Report
Summary
@clerk/sharedCurrent version: 4.21.0 Subpath
|
84fb3e9 to
3110987
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/shared/src/types/organizationDomain.ts (1)
37-81: 🗄️ Data Integrity & Integration | 🔵 TrivialPublic JSDoc changed on exported organization-domain types; Docs team review may be needed.
The ownership status union is aligned with the API (
unverified|verified|expired), so there’s nofailedownership state to add. Affiliation verification still uses its separatefailed/expiredstatuses.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/shared/src/types/organizationDomain.ts` around lines 37 - 81, The exported organization-domain JSDoc in OrganizationDomainOwnershipVerificationStatus and OrganizationDomainOwnershipVerification should only describe the API-aligned ownership states, so remove any ownership wording that implies a `failed` status and keep `failed` only in OrganizationDomainVerificationStatus. Update the comments on the ownership status union and the status field in OrganizationDomainOwnershipVerification to reflect `unverified` | `verified` | `expired`, and keep the verification type docs distinct from the ownership docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/ripe-ways-greet.md:
- Around line 2-8: Update the changeset entry to use minor instead of patch for
`@clerk/shared`, `@clerk/ui`, `@clerk/localizations`, and `@clerk/clerk-js`, since the
self-serve SSO expired-organization-domain handling introduces a new public
feature; edit the changeset metadata in the ripe-ways-greet changeset so the
release versioning matches the added API surface.
---
Nitpick comments:
In `@packages/shared/src/types/organizationDomain.ts`:
- Around line 37-81: The exported organization-domain JSDoc in
OrganizationDomainOwnershipVerificationStatus and
OrganizationDomainOwnershipVerification should only describe the API-aligned
ownership states, so remove any ownership wording that implies a `failed` status
and keep `failed` only in OrganizationDomainVerificationStatus. Update the
comments on the ownership status union and the status field in
OrganizationDomainOwnershipVerification to reflect `unverified` | `verified` |
`expired`, and keep the verification type docs distinct from the ownership docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 332bf84b-f9aa-41be-a88b-aa93d73ad55e
📒 Files selected for processing (9)
.changeset/ripe-ways-greet.mdpackages/localizations/src/en-US.tspackages/shared/src/react/hooks/useOrganizationDomains.tsxpackages/shared/src/types/json.tspackages/shared/src/types/localization.tspackages/shared/src/types/organizationDomain.tspackages/ui/src/components/ConfigureSSO/steps/OrganizationDomainsStep.tsxpackages/ui/src/customizables/elementDescriptors.tspackages/ui/src/internal/appearance.ts
3110987 to
39becf2
Compare
39becf2 to
ef0890b
Compare
Description
This PR handles the expired state of an organization domain, allowing to trigger another verification with fresh TXT records.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Bug Fixes