Skip to content

chore: fix dev / turbo.json #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiskevinwang wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −4
Open

chore: fix dev / turbo.json #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/localizations/tsdown.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import { defineConfig } from 'tsdown';

export default defineConfig(overrideOptions => {
const shouldPublish = !!overrideOptions.env?.publish;
export default defineConfig(({ env, watch }) => {
const shouldPublish = !!env?.publish;

return {
entry: ['src/*.ts'],
format: ['cjs', 'esm'],
fixedExtension: false,
clean: true,
// Keep the previous build in place during watch rebuilds so downstream
// dev servers never resolve package exports against an empty dist.
clean: !watch,
minify: false,
sourcemap: true,
dts: true,
Expand Down
4 changes: 3 additions & 1 deletion packages/shared/tsdown.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ export default defineConfig(({ watch, env }) => {
{
...common,
dts: false,
clean: true,
// Keep the previous build in place during watch rebuilds so downstream
// dev servers never resolve package exports against an empty dist.
clean: !watch,
external: ['react', 'react-dom'],
onSuccess: shouldPublish ? 'pkglab pub --ping' : undefined,
// Route rolldown's shared chunks into a nested `_chunks/` directory. The
Expand Down
16 changes: 16 additions & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,22 @@
"dev": {
"cache": false
},
"@clerk/clerk-js#dev": {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required changeset

The root /workspace/javascript/AGENTS.md requires every PR to include a changeset, using pnpm changeset:empty for tooling/repo-only changes. This commit changes the dev/build pipeline but adds no .changeset entry, so the release metadata requirement for this PR is unmet; add an empty changeset if there is no user-facing package impact.

Useful? React with 👍 / 👎.

"cache": false,
"dependsOn": ["@clerk/shared#build"]
},
"@clerk/ui#dev": {
"cache": false,
"dependsOn": ["@clerk/shared#build", "@clerk/localizations#build"]
},
"@clerk/shared#dev": {
"cache": false,
"dependsOn": ["@clerk/shared#build"]
},
"@clerk/localizations#dev": {
"cache": false,
"dependsOn": ["@clerk/localizations#build"]
},
"dev:current": {
"cache": false,
"dependsOn": ["^build", "dev"],
Expand Down
Loading