test: remove unreachable code in GetServerVersion (#48)

[talmacschen-arch]

What

Removes the unreachable code block at the end of GetServerVersion in testutils/functions.go.

Why

go vet ./... reports one warning on main:

# github.com/cloudberry-contrib/cbcopy/testutils
testutils/functions.go:648:2: unreachable code

GetServerVersion returns serverVersion early, so the trailing regexp-extraction block (a comment block + regexp.MustCompile + return match) is dead code — never executed. The function has no callers in the repo, so there is no intended behavior to preserve; the safe, minimal fix is to drop the unreachable block.

Verification

• gofmt -l — clean
• go vet ./... — now clean (warning gone)
• go build ./... — passes
• make unit — all 5 suites pass (dbconn 12/12, backup 469/470 + skips, TOC 45/45, testutils 8/8, utils 58/58)

regexp is still imported and used by the sibling GetPslVersion, so no import change is needed. No behavior change.

Fixes #48

Summary by CodeRabbit

• Bug Fixes
  • Improved server version reporting by preserving the complete version output returned by the database client.
  • Removed unnecessary version parsing that could omit non-numeric version details.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ea152f8-3284-467c-aba7-1305062ca81f

📥 Commits

Reviewing files that changed from the base of the PR and between b100694 and 2a1ea9f.

📒 Files selected for processing (1)

• testutils/functions.go

💤 Files with no reviewable changes (1)

• testutils/functions.go

---

📝 Walkthrough

Walkthrough

GetServerVersion now returns the trimmed raw output from psql directly. The unreachable regular-expression parsing and related version comments were removed.

Changes

Server version output

Layer / File(s)	Summary
Remove unreachable version parsing testutils/functions.go	GetServerVersion returns the complete trimmed psql output and removes the unreachable regex-based numeric extraction.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: removing unreachable code in GetServerVersion.
Description check	✅ Passed	The description explains the change, motivation, and verification, with the linked issue referenced.
Linked Issues check	✅ Passed	The PR removes the dead code block that triggers the reported go vet warning, matching issue #48.
Out of Scope Changes check	✅ Passed	The changes stay narrowly focused on deleting unreachable code in testutils/functions.go.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[leaocx]

LGTM. Clean removal of unreachable code.

• Confirmed the code after return serverVersion is indeed dead
• GetServerVersion has no callers in the repo
• regexp import is still used by GetPslVersion, no import change needed
• No behavior change