Fix additionalConfiguration not mapped during YAML IdP bootstrap#3985
Open
duanemay wants to merge 1 commit into
Open
Fix additionalConfiguration not mapped during YAML IdP bootstrap#3985duanemay wants to merge 1 commit into
duanemay wants to merge 1 commit into
Conversation
OauthIDPWrapperFactoryBean#setCommonProperties() maps nearly every field from a YAML-defined OAuth/OIDC identity provider onto the provider definition, but silently skipped additionalConfiguration. As a result, any provider bootstrapped from YAML always ends up with additionalConfiguration == null, even when the manifest sets it, while providers created/updated via the REST API are unaffected since Jackson deserializes the field correctly there. Add the missing mapping, following the same pattern used for the other fields in this method, and add test coverage for both the mapped and not-provided cases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a YAML-bootstrap gap in the OAuth/OIDC identity provider factory so that additionalConfiguration from uaa.yml is propagated onto the resulting AbstractExternalOAuthIdentityProviderDefinition (matching REST/Jackson behavior).
Changes:
- Map
additionalConfigurationinOauthIDPWrapperFactoryBean#setCommonProperties(...). - Add unit tests verifying mapping when present and
nullpassthrough when absent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIDPWrapperFactoryBean.java | Adds the missing additionalConfiguration mapping during YAML IdP bootstrap. |
| server/src/test/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIdentityProviderDefinitionFactoryBeanTest.java | Adds coverage ensuring the new mapping is applied and remains null when not provided. |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
strehle
approved these changes
Jul 18, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OauthIDPWrapperFactoryBean#setCommonProperties()maps nearly every field from a YAML-defined OAuth/OIDC identity provider onto the provider definition object (attributeMappings,scopes,issuer, etc.), but silently skippedadditionalConfiguration.additionalConfiguration == null, regardless of what the manifest sets. Providers created/updated via the REST API are unaffected, since Jackson deserializes the field correctly there.Test plan
additionalConfigurationIsMapped— verifies a YAML map containingadditionalConfigurationis reflected on the definition object aftersetCommonProperties.additionalConfigurationIsNullWhenNotProvided— verifies null passthrough when the key is absent.OauthIdentityProviderDefinitionFactoryBeanTestlocally — all 26 tests pass.🤖 Generated with Claude Code