chore: Styling v2 utils, part 1#4720
Open
pan-kot wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4720 +/- ##
==========================================
- Coverage 97.59% 97.59% -0.01%
==========================================
Files 950 950
Lines 30664 30690 +26
Branches 11242 11255 +13
==========================================
+ Hits 29928 29953 +25
- Misses 689 690 +1
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fdc10f2 to
e13f24a
Compare
e13f24a to
b6f5185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing the first set of Style API v2 utils, see QUIP [RF7BAXdY9QZb] and [3LQzAqi0WIlT]. These utils were originally added in the POC implementation (#4577), but here I am adding them as a standalone change, covered with a dedicated test page (to be covered with screenshot tests). Compared to the POC, I introduced a few small ergonomics/naming changes.
Once this one is merged, I will follow it up by a few more similar PRs - introducing shared token groups (surface, focus outline, etc.), and a mechanism to extract style tokens documentation.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.