fix: vertically center chart tooltip and legend markers#4723
Open
ClaudioGSDB wants to merge 1 commit into
Open
fix: vertically center chart tooltip and legend markers#4723ClaudioGSDB wants to merge 1 commit into
ClaudioGSDB wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4723 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 950 950
Lines 30690 30690
Branches 11254 11254
=======================================
Hits 29953 29953
Misses 730 730
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SpyZzey
approved these changes
Jul 14, 2026
pan-kot
requested changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Chart series markers weren't vertically centered against their label in tooltips (and legends) - the marker sat low/high depending on type, because each marker carried a hardcoded
margin-block-startto fake alignment under atop-aligned(flex-start) row.Fix - center the row and drop the magic margins so alignment is geometric:
align-items: centerinstead offlex-start.align-items: center.margin-block-startfrom.marker,.marker--line, and.marker--dashed.Affects chart tooltips and legends (shared marker), so expect visual-snapshot diffs across those. Note: multi-line tooltip keys now center the marker against the whole block rather than the first line.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.