ci(cora): add cora review, PR checks, CLA, pre-commit hook, split CI jobs - #27
Merged
Merged
Conversation
…jobs ## What - Split CI into separate jobs (check, fmt, clippy, test, build, verify-templates, mutation-testing) - Add Cora AI Code Review workflow (cora-review.yml) - Add PR Checks workflow (branch naming, conventional commits, PR template validation) - Add CLA Check workflow - Add PR template (.github/PULL_REQUEST_TEMPLATE.md) - Add pre-commit hook (.githooks/pre-commit) with cora review support ## Why Adopt standard CI patterns from uteke and cora-code repos. Cora review catches code quality issues before merge. PR checks enforce consistent branch naming, conventional commits, and complete PR descriptions. Pre-commit hook runs fmt + clippy + cora locally to catch issues before push. ## How - CI: separate jobs for faster feedback (fmt/clippy fail fast, test/build run in parallel) - cora-review.yml: uses codecoradev/cora-review-action@v1 with BYOK secrets - pr-checks.yml: validates branch name prefix, PR body sections (## What/Why/Testing), conventional commit title - cla-check.yml: fetches signatures from codecoradev/.github, posts comment if unsigned - pre-commit hook: adaptive language detection (Rust/TS/Go/Python), runs cora if binary exists - Secrets: CORA_API_KEY, CORA_BASE_URL, CORA_MODEL set as repo-level GitHub secrets ## Testing - CI yaml validated with actionlint - All workflows use actions/checkout@v4, Swatinem/rust-cache@v2, dtolnay/rust-toolchain@stable - Pre-commit hook tested locally (fmt + clippy clean) ## Related Issues - Adopts patterns from codecoradev/uteke and codecoradev/cora-code ## Checklist - [x] Branch name follows convention (ci/cora-review-and-pr-checks) - [x] Branch is from develop - [x] Commit messages follow Conventional Commits - [x] No secrets or credentials committed - [x] One logical change per PR (CI/CD improvements)
🔍 Cora AI Code ReviewReview powered by cora-code · BYOK · MIT |
gradient-card template only exists in feat/test-suite branch, not develop. og-image is available in develop and tests a different aspect ratio.
Mutation testing takes 40+ minutes. CI should be fast feedback. cargo-mutants + cargo-mutants.toml config stay for local use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Adopt standard CI patterns from
utekeandcora-coderepos. Cora review catches code quality issues before merge. PR checks enforce consistent branch naming, conventional commits, and complete PR descriptions. Pre-commit hook runs fmt + clippy + cora locally to catch issues before push.How
Patterns adopted directly from the reference repos:
ci.ymlcora-review.ymlcora-review-action@v1+ BYOK secretspr-checks.ymlcla-check.ymlcodecoradev/.github.githooks/pre-commitPULL_REQUEST_TEMPLATE.mdCI improvements:
actions/cache@v4→Swatinem/rust-cache@v2(smarter caching)RUST_BACKTRACE: 1+FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: truecontinue-on-error(informational, non-blocking)Pre-commit hook usage:
Testing
actions/checkout@v4,Swatinem/rust-cache@v2,dtolnay/rust-toolchain@stableCORA_API_KEY,CORA_BASE_URL,CORA_MODEL(repo-level)Related Issues
Adopts patterns from
codecoradev/utekeandcodecoradev/cora-code.Checklist
ci/cora-review-and-pr-checks)develop