docs(benchmark): fix v0.19.0 chart bottom spacing (tick gap + divider) - #1297
Merged
Merged
Conversation
Owner review feedback: tick row hugged the last bar; add hairline divider above footer. Data unchanged.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates
docs/assets/longmemeval-recall-v019.pngwith corrected bottom spacing: the 0-100% axis tick row moves from flush-against-the-last-bar to a ~36px gap below it (matching the approved v0.17.0 chart's rhythm), a subtle hairline divider is added between the chart body and the footer block, and the footer lines sit lower in the canvas. No text or data changes: same headline (98.2%), same badge, same footer copy.Why
Owner review feedback on the merged chart (2026-09-29): the tick row hugged the agentmemory bar (0-5px gap) and the card lacked a visible separation before the footer. Pixel-verified on the regenerated render: bar bottom y
524, ticks y563-577, divider (rgb 48,48,62) at y=594, footer y~606-670, all within the 720px canvas.Testing