fix: Prevent JSON SyntaxError on non-2xx API responses - #165
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Bundle ReportChanges will increase total bundle size by 245 bytes (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser extension was encountering
SyntaxError: Unexpected token 'F', "Forbidden" is not valid JSONwhen making API calls to Codecov. This occurred because the Codecov API returns a plain-text "Forbidden" message with a 403 status code when authentication or authorization fails. ThefetchCommitReport,fetchPRComparison,listFlags, andlistComponentsmethods insrc/service.tswere unconditionally callingresponse.json()on these non-JSON responses, leading to the error.This fix modifies these four methods to check
response.okbefore attempting to parse the response as JSON. Ifresponse.okis false, the methods now return{ ok: false, data: null }, preventing theSyntaxErrorand allowing upstream callers (which already handleok: false) to gracefully manage the API error.Fixes BROWSER-EXTENSION-RM
This PR was automatically generated by Sentry. You can adjust this setting at any time.