Skip to content

fix(graphql): accept ref argument on CommitCoverageAnalytics.coverageFile - #2203

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/graphql-coverage-file-ref
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/graphql-coverage-file-ref

Conversation

@sentry

@sentry sentry Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

An external client was sending a GraphQL query to CommitCoverageAnalytics.coverageFile with an unsupported ref argument, leading to GraphQLError: Unknown argument 'ref'.

This change updates the GraphQL schema and resolver for coverageFile to accept ref as an optional String argument. The argument is accepted but ignored, as the commit context is already provided by the parent commit(id:...) field, making the ref redundant. This prevents the GraphQL validation error for clients sending this legacy argument.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes API-F09

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@thomasrockhu-codecov

thomasrockhu-codecov commented Sep 6, 2026

Copy link
Copy Markdown
Contributor
✨ Harness AI Code Review View in Harness →

Risk: LOW

This PR adds an optional ref: String argument to the CommitCoverageAnalytics.coverageFile GraphQL field and threads a matching ref=None keyword into the resolve_coverage_file resolver. The argument is intentionally accepted-and-ignored to unblock a legacy external client that was hitting Unknown argument 'ref'; the commit context still comes from the parent commit(id:...) field, so the resolver behavior is unchanged. The schema and resolver signatures stay in sync and the added parameter has a safe default, so there is nothing to fix.

No issues found above the confidence threshold.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (17e0f08) to head (c217e5c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2203   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files        1337     1337           
  Lines       53262    53262           
  Branches     1647     1647           
=======================================
  Hits        48805    48805           
  Misses       4136     4136           
  Partials      321      321           
Flag Coverage Δ
apiunit 93.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant