fix(torngit): handle ValueError in diff_to_json unpacking - #2322
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
ValueError: not enough values to unpack (expected 2, got 1)occurring inshared/torngit/base.pywithin thediff_to_jsonmethod.The root cause was identified as
diff_to_json's naive string splitting by"\ndiff --git a/". When a file's patch content (e.g., a test fixture or embedded patch) itself contained a line starting withdiff --git a/, it created a spurious extra split point. This resulted in a malformed diff chunk whose first 'line' lacked the expected" b/"separator, causing thesplit(" b/", 1)call to return only one element, leading to theValueErrorduring tuple unpacking.The fix extends the existing
except IndexErrorclause to also catchValueError. The subsequent fallback logic, which scans for--- a/and+++ b/lines, is already robust enough to handle these malformed chunks by either correctly identifying the filenames or, if no valid headers are found, allowing the chunk to be safely skipped.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-Z8M
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.