Skip to content

fix(torngit): handle ValueError in diff_to_json unpacking - #2322

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/diff-to-json-valueerror-hjcxhT
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/diff-to-json-valueerror-hjcxhT

Conversation

@sentry

@sentry sentry Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This PR addresses a ValueError: not enough values to unpack (expected 2, got 1) occurring in shared/torngit/base.py within the diff_to_json method.

The root cause was identified as diff_to_json's naive string splitting by "\ndiff --git a/". When a file's patch content (e.g., a test fixture or embedded patch) itself contained a line starting with diff --git a/, it created a spurious extra split point. This resulted in a malformed diff chunk whose first 'line' lacked the expected " b/" separator, causing the split(" b/", 1) call to return only one element, leading to the ValueError during tuple unpacking.

The fix extends the existing except IndexError clause to also catch ValueError. The subsequent fallback logic, which scans for --- a/ and +++ b/ lines, is already robust enough to handle these malformed chunks by either correctly identifying the filenames or, if no valid headers are found, allowing the chunk to be safely skipped.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-Z8M

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codspeed

codspeed Bot commented Sep 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing seer/fix/diff-to-json-valueerror-hjcxhT (3fe1384) with main (17e0f08)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (1c2ed4e) during the generation of this report, so 17e0f08 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sentry

sentry Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Sentry needs additional GitHub App permissions

The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing.

Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants