perf(worker): Batch insert uploads and flags in save_full_report - #2333
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue in the
save_full_reportmethod withinapps/worker/services/report/__init__.py.Problem:
Previously, the
save_full_reportmethod performed multipledb_session.flush()calls inside a loop iterating over report sessions. Specifically:Uploadinsert._attach_flags_to_uploadfor newRepositoryFlagcreation and after associating flags.UploadLevelTotalsinsert.This resulted in an O(N * M) number of database round-trips for N sessions with M flags each, leading to significant performance degradation for large reports.
Solution:
The
save_full_reportmethod has been refactored to batch database operations, drastically reducing the number of flushes. The process now involves:RepositoryFlagobjects are created and added to the session, followed by a singledb_session.flush()to assign their IDs.Uploadobjects are constructed and added to the session. A singledb_session.flush()is then called to persist them and retrieve their database-assigned IDs.upload.flagsare assigned to eachUploadobject. SQLAlchemy efficiently queues theuploadflagmembershipassociation rows in memory without immediate database interaction.UploadLevelTotalsobjects are created and added to the session. A finaldb_session.flush()is performed, which persists these totals and also writes all the previously queueduploadflagmembershipassociation rows.Additionally, the redundant
db_session.flush()call within_attach_flags_to_upload(line 313) has been removed, as flag associations are now handled by the bulk flush insave_full_report.This change reduces the number of database flushes from O(N*M) to a constant maximum of 3-4 flushes per
save_full_reportcall, significantly improving performance.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-VHG
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.