chore(deps): stop declaring lucene-grouping and lucene-spatial-extras - #48
Merged
Merged
Conversation
After the forked tree was pruned, none of its classes refers to either module, and neither does any consumer. GeoUtils still imported two prefix-tree classes it never used; those imports go with the dependencies. Consumers such as Fess ship 0.33 MiB less. The remaining seven Lucene modules are still referenced and stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the forked tree was pruned, none of its classes refers to
lucene-groupingorlucene-spatial-extras, and no consumer does either — Fess, fess-suggest, fess-crawler-opensearch and the current snapshot jar of every Fess plugin were scanned. They still ship with every Fess distribution: 0.343 MiB.GeoUtilsstill importedGeohashPrefixTreeandQuadPrefixTreewithout using them (they do not appear in its bytecode), so those two imports go with the dependencies. The other seven Lucene modules are still referenced and stay.Verification
mvn test: 636 tests, 0 failures, 0 errors.mvn clean testagainst it: 7,486 tests, 0 failures, 0 errors.