docs(15.9): the Groovy script plugin is no longer bundled - #525
Merged
Conversation
codelibs/fess#3425 stopped fetching fess-script-groovy at prepare-package and shipping it in WEB-INF/plugin, so 15.9 itself is the release where the plugin has to be installed. The two pages that describe the engine still said it was bundled in 15.9 and would stop being bundled in 15.10, which is now wrong in both halves: an installation that upgrades to 15.9 and does nothing loses Groovy, and there is no 15.10 transition left to prepare for. Both pages now say the plugin is not part of the distribution and name the two ways to install it: the System > Plugin page in the admin UI, and `bin/fess-setup install plugin fess-script-groovy`. The manual-install example moves from 15.10.0 to 15.9.0 for the same reason. The eight other pages that mention the plugin already phrase it as "requires the fess-script-groovy plugin" and needed no change, and install/upgrade.rst already described the 15.9 behaviour correctly. All seven languages. Each file was parsed with docutils before and after the edit, with doctitle_xform=False the way Sphinx parses: no new system messages, and no bold or literal markup left unparsed in the rendered text. The Chinese cell keeps CJK punctuation directly before the bold start-string, which 58 existing places in zh-cn/15.9 already rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codelibs/fess#3425 stopped fetching
fess-script-groovyatprepare-packageand shipping it inWEB-INF/plugin, so 15.9 itself is the release where the plugin has to be installed.Two pages in the 15.9 tree still described the plan that PR replaced:
config/scripting-groovy.rstconfig/scripting-overview.rstBoth halves are wrong now: an installation that upgrades to 15.9 and does nothing loses Groovy, and there is no 15.10 transition left to prepare for.
Both pages now say the plugin is not part of the distribution and name the two ways to install it — the System > Plugin page in the admin UI, and
bin/fess-setup install plugin fess-script-groovy, which is the exact formFessSetupprints in its own usage error. The manual-install example moves fromfess-script-groovy-15.10.0.jarto15.9.0.jarfor the same reason.What did not need changing
The eight other pages in the 15.9 tree that name the plugin already phrase it as "requires the
fess-script-groovyplugin", andinstall/upgrade.rstalready described the 15.9 behaviour correctly. Nothing outside the 15.9 development tree was touched.Verification
Seven languages, two files each. Each file was parsed with docutils before and after the edit using
doctitle_xform=False, the way Sphinx parses, and the two results compared:The second check is the one that matters here, because docutils requires whitespace or punctuation around an inline start-string and fails silently when a CJK character sits directly against it. It was confirmed to be a real check rather than a vacuous one by feeding it a known-broken
text**bold**more, which it flags.