docs: use the jcifs 3.x property names in the JVM options defaults - #532
Merged
Conversation
The documented defaults for jvm.crawler.options and jvm.thumbnail.options listed seven jcifs system properties under names no supported jcifs version reads. jcifs 3.0.0 dropped the .smb segment from every key and folded the legacy SMB1 stack onto the same keys, so both jcifs.smb.client.* and jcifs.smb1.smb.client.* are ignored. Match the corrected defaults in codelibs/fess#3433: four properties under jcifs.client.*, and the three jcifs.smb1.smb.client.* duplicates removed because the legacy stack now reads the same keys. Only en/15.9 documents these options; no other language tree in the development version lists them.
This was referenced Sep 10, 2026
docs(config): mark the group headings and describe the 24 undocumented properties
codelibs/fess#3434
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation half of codelibs/fess#3433, itself a follow-up to codelibs/jcifs#81.
config/properties.rstdocuments the shipped defaults ofjvm.crawler.optionsandjvm.thumbnail.options, which included seven jcifs system properties:None of them are read by the jcifs version Fess ships. 3.0.0 dropped the
.smbsegment from every configuration key and folded the legacy SMB1 stack onto the same
keys, so both spellings are ignored without error. Anyone copying these lines out of
the documentation to tune SMB crawl timeouts got no effect and no diagnostic.
This brings the documented defaults in line with codelibs/fess#3433: the four
properties are renamed to
jcifs.client.*, and the threejcifs.smb1.smb.client.*lines are dropped rather than renamed, because since 3.0.0 the legacy stack reads the
same
jcifs.client.*keys and keeping them would just duplicate the flags.Scope
Only
en/15.9documents these JVM options —grepover the development tree findsjvm.crawler.optionsin the Englishconfig/properties.rstalone. The other sixlanguage trees mention jcifs only in a prose aside in
config/crawler-advanced.rst("approximately 40 options covering jcifs SMB timeouts, ..."), which names no
properties. The real count goes 39 to 36, still within "approximately 40", so those
lines are left alone.
Per the project convention this touches the development tree (
versions.jsondevelopment= 15.9) only; released trees are not backported.