chore: fix packaging metadata, dependency alerts and Docker tag guidance - #36
Merged
Conversation
Follow-ups noticed while cutting the 0.3.0 release. - pyproject.toml: drop the typer[all] extra. typer 0.16.0 publishes no "all" extra, so uv warns on every install; relocking changes no resolved package, confirming the extra was already a no-op. - uv.lock: refresh the transitive dependencies Dependabot flagged -- urllib3 2.5.0 -> 2.7.0, idna 3.11 -> 3.19, requests 2.32.5 -> 2.34.2, pytest 9.0.1 -> 9.1.1, python-dotenv 1.2.1 -> 1.2.3 and pygments 2.19.2 -> 2.21.0. The pinned direct dependencies are untouched. - skills docs: tags on ghcr.io/codelibs/fessctl are fessctl release versions, not Fess versions, and no "latest" tag is published. The detection chain built the tag out of FESS_VERSION, which names a tag that has never existed, and the troubleshooting page recommended the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three follow-ups noticed while cutting the 0.3.0 release. No runtime code changes.
1.
typer[all]is not a real extratyper 0.16.0 publishes no
allextra, so every install prints:Relocking after removing it changes no resolved package, which confirms the extra
was already a no-op — plain
typerpulls click, rich, shellingham andtyping-extensions on its own.
2. Dependency alerts
All nine open Dependabot alerts are transitive packages in
uv.lock. Upgraded withtargeted
uv lock --upgrade-packageso the pinned direct dependencies(
httpx==0.28.1,pyyaml==6.0.2,typer==0.16.0) stay exactly as they are:3. Docker tag guidance in the skill docs was wrong
Image tags on
ghcr.io/codelibs/fessctlare fessctl release versions (0.1.0,0.2.0,0.3.0, plussnapshot). The docs described them as tracking the Fessversion, which is selected at runtime by
FESS_VERSIONand has nothing to do with thetag. The install skill's runner detection therefore built an image reference that can
never resolve:
There is also no
latesttag on this image, so the fallback was equally broken and thetroubleshooting page recommended it too. Fixed in
references/installation.md(runnerdetection now pins
0.3.0; the "Choosing the Docker tag" section states what tags mean)and
references/troubleshooting.md(a missing tag fails withmanifest unknown, notdenied, so both error strings are now covered).Verification
uv run pytest tests/unit— 123 passed with the upgraded lockfiledocker pull ghcr.io/codelibs/fessctl—manifest unknown(confirms nolatesttag)docker run ... ghcr.io/codelibs/fessctl:0.3.0— reports package version0.3.0,default
FESS_VERSION15.8.0