Skip to content

SECURITY fix(souslet): bind deployed containers to loopback, not 0.0.0.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemug merged 1 commit into from
Sep 3, 2026
Merged

SECURITY fix(souslet): bind deployed containers to loopback, not 0.0.0.0 #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cmd/souslet/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,19 @@ func main() {
log.Fatalf("build TLS config: %v", err)
}

dockerEngine, err := engine.New("", *gpuDriver)
// *bindHost, NOT "". engine.Docker's own bindHost is what actually
// controls a deployed container's PortBindings HostIP - an empty
// string there makes Docker bind 0.0.0.0 (every interface), not
// "unset, so default to loopback". Handlers.BindHost (below) only
// controls the PORT ALLOCATION PROBE, a separate concern from what a
// container actually publishes on - passing "" here left every
// souslet-deployed model reachable directly on the node's tailnet IP,
// bypassing the mTLS-gRPC-tunnel-only design entirely (see stacks/
// souslet/docker-compose.yml in the fleet repo's own account of why
// that boundary matters). cmd/sous-api/main.go's equivalent call
// already does this correctly (engine.New(cfg.Host(), "cdi")) - this
// was souslet-specific.
dockerEngine, err := engine.New(*bindHost, *gpuDriver)
if err != nil {
log.Fatalf("connect to local Docker: %v", err)
}
Expand Down
Loading