🤖 fix: prevent transcript loading indicator layout flash - #4163
Conversation
Keep transient loading feedback out of the in-flow composer dock; add desktop and phone replay geometry regression coverage. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `medium` • Cost: `$9.15`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=medium costs=9.15 -->
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a77ee000d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
--- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `medium` • Cost: `$9.15`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=medium costs=9.15 -->
|
@codex review |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex approved commit 096c620 with no major issues, and both security reviews reported no security issues. The legacy Codex Comments gate treats the two clean-security informational comments as unresolved findings; marking those informational comments resolved (collapsed, not deleted) so the gate can reflect the actual review result. The substantive tail-overlap finding was fixed and its thread resolved. |
Summary
Fix the transcript layout flash caused by the “Loading messages” indicator during history catch-up. Keep loading feedback out of the composer’s normal layout flow so its appearance/removal cannot resize the dock or move cached messages.
Background
Regression introduced by #4125, “🤖 feat: show chat history loading above the composer” (commit
d8d368d4bfd49f7b761e6b19d2923b0865458f07). That change inserted a transient 24px row into the in-flow composer dock, changing transcript geometry on workspace switches and catch-up completion.Implementation
Validation
make static-checkpassed.Risks
The indicator is now a small overlay above the composer rather than an extra row. History/subscription state and composer behavior are unchanged. Desktop-agent visual inspection was unavailable in this SSH environment; responsive checks ran in real Chromium via the pinned-phone story.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:medium• Cost:$9.15